Draft: Polaris frame, Modals, and more!#8
Conversation
| </div> | ||
|
|
||
| <div | ||
| className="main-content" |
There was a problem hiding this comment.
I wish I could just use <Frame /> from Polaris React 😭
| /** | ||
| * Print configuration summary | ||
| */ | ||
| function printConfigSummary(config: MockShopifyAdminConfig): void { |
There was a problem hiding this comment.
I found that this print ended up being inaccurate when my config file was applied
| .argument('[app-url]', 'Your app\'s URL (e.g., http://localhost:3000/shopify)') | ||
| .option('-i, --client-id <id>', 'Your Shopify app\'s client ID (optional, defaults to development ID)') | ||
| .option('-s, --client-secret <secret>', 'Mock client secret (development only)') | ||
| .option('--shop <domain>', 'Mock shop domain', 'test-shop.myshopify.com') |
There was a problem hiding this comment.
There's probably a better way, but this default was overriding my config
|
Now that I think about it, a better way to handle modal lifecycle would be to implement web components for them :P |
|
Is there any chance we'll get this in? This is like the missing link in Shopify App Development :) |
|
@Kashuab Hey wow, thanks for the huge PR. I assume because you marked it as a WIP, that it's not ready to merge yet - or am I holding this back? I'm definitely open to merge your improvements. |
|
@Kashuab Hey, I’m really excited for this PR to be merged—been waiting on it. Just one question: are you also planning to add resource picker support? |
|
Don't want to step on your toes @Kashuab, really appreciate your time spent on it. I may just checkout this branch to test/edit and merge. Seems like an overall improvement and I don't want to hold it back. |
|
Hey! Sorry for the delay. Feel free to do whatever you want with this
branch!
A lot of my off-time has been consumed by a new side project I'm working
on. It's an async claude agent engine, and as our team adopts it we'll very
soon want mock bridge even more.
So hopefully I'll carve some time to return to this!
…On Thu, Feb 5, 2026 at 10:36 AM Dylan Pierce ***@***.***> wrote:
*ctrlaltdylan* left a comment (ctrlaltdylan/mock-bridge#8)
<#8 (comment)>
Don't want to step on your toes @Kashuab <https://github.com/Kashuab>,
really appreciate your time spent on it.
I may just checkout this branch to test/edit and merge. Seems like an
overall improvement and I don't want to hold it back.
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQKHKNLILXC2ZULZJXWHHAT4KOESZAVCNFSM6AAAAACLRVBW2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNJVGM4TINRQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
No worries! Heck yeah. That sounds awesome, completing the entire dev -> testing feedback loop. |
|
Merged! Added local testing as well, and more model context. |
4 participants
Disclaimer: This is a draft PR, still some more work to do :) Please feel free to take a look though!
Related issues #2, #7, #5, #4, #3
Hey! I finally got some time to sink my teeth into this. 😄
This PR has a lot of changes, and will probably get more as I continue to flesh out modals. My goals were:
postMessagecomms between the admin frame and client app bridgeIn doing so, I've introduced a plethora of changes:
--shopwould override the shop I have set in configiframesrcviaid_tokenparam, my Remix app needed thiswindow.shopifydefinition, give those a place to live for future iterationPLEASE ask me all the questions and give any feedback (maybe aside from code review, it's unfinished!) Let me know if this is in-line with your vision or if there is some contribution etiquette I'm missing!
So much more
TODO, including adding more info to this description. It's Saturday evening and I'm craving some brew 🍺Remaining tasks in this PR:
MutationObserverworks properly, modal content should be dynamic, unmounting should invoke cleanup, etc.)invokeFeatureis fine for unidirectional/opaque flow (app iframe -> parent) but what if the parent wants to return data? 🤔